Conversation
|
Thank you for the PR. I can't review it well right now, I hope I will return to it in two weeks or so. But I've checked briefly and I think there is a better place for blocking the press event: Anyway, need to check if it's the same behavior as Swing does when pressing copy and paste keystrokes. If Swing sends a KEY_TYPED event, then we should do it too and solve PRJ-380 and PRJ-426 in some other way... |
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
============================================
- Coverage 22.18% 22.18% -0.01%
Complexity 57 57
============================================
Files 160 160
Lines 4142 4143 +1
Branches 576 577 +1
============================================
Hits 919 919
- Misses 3201 3202 +1
Partials 22 22
Continue to review full report at Codecov.
|
|
Well, looks like I'm stuck with rendering-related tickets now and I can't spend time on digging into keyboard problems in the near future. As I noted before, this PR can't be accepted as is: some changes are required at least, and some research is needed too. So let me postpone the review of this PR. |
For PRJ-380 and PRJ-426, I believe that we can merely send copy/paste events to projector-server without the extra "c" and "v", aiming at avoiding the useless character displayed in the terminal.