This repository was archived by the owner on Mar 26, 2024. It is now read-only.
Conversation
SerVB
approved these changes
Mar 29, 2022
Member
SerVB
left a comment
SerVB
left a comment
There was a problem hiding this comment.
Cool! But jcef is a big branch and it's unclear when we merge it. Can I ask you to port these chances to master so we can apply them faster? For example, rebase this PR to master (and change the target branch), but apply move these changes directly to the jcef branch.
Contributor
Author
|
It's easier to make a new branch because changes in this PR affect file introduced in jcef branch and doesn't exist in master. Is it ok for you? |
Member
|
@ARTI1208 , ok, of course |
Contributor
Author
|
Can I just push to master then since you already reviewed? |
Member
|
Sure |
a2425rdl
suggested changes
Nov 27, 2022
a2425rdl
left a comment
a2425rdl
left a comment
There was a problem hiding this comment.
17f8bd926464a1afa4c6a11669539e9c1ba77048
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.