Start using `Stability.Runtime` more broadly by derekxu16 · Pull Request #5705 · JetBrains/kotlin

derekxu16 · 2026-02-27T16:17:48Z

This PR makes it so that if an element depends on the stability of an internal or public class defined in another file, the element will no longer infer the stability of that class and will depend on the runtime stability of that class instead.

Bug: 427530633

kotlin-safe-merge · 2026-02-27T16:17:54Z

Code Owners

Rule	Owners	Approval
`/libraries/tools/kotlin-gradle-plugin-integration-tests/`, `/libraries/tools/kotlin-gradle-plugin-integration-tests/src/test/resources/*/.gradle.kts`	kotlin-build-tools	❌
`/plugins/compose/`	`@ShikaSD`, `@andrewbailey`, `@bentrengrove`, `@chuckjaz`, `@derekxu16`	❌

...sted/src/main/java/androidx/compose/compiler/plugins/kotlin/lower/AbstractComposeLowering.kt

ShikaSD

Great job here! A few top level comments:

Let's extract interface Unstable -> Uncertain change into a separate commit, it is an impactful change and having it separately will make it easier to review / revert.
Could you remind me why we cannot generate static val $stable anymore? Can we only change it to getters for internal classes? I would love us to generate a minimal amount of code when possible considering code size concerns expressed by 1p.

.../src/jvmTest/kotlin/androidx/compose/compiler/plugins/kotlin/ClassStabilityTransformTests.kt

....compiler.plugins.kotlin.ClassStabilityTransformTests/testComposableCall[useFir = false].txt

...ilityTransformTests/testComposableCallWithUnstableFinalClassInSameModule[useFir = false].txt

...in.RememberIntrinsicTransformTests/testRememberInALoop_NoTrailingRemember[useFir = true].txt

...compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/analysis/Stability.kt

...sted/src/main/java/androidx/compose/compiler/plugins/kotlin/lower/AbstractComposeLowering.kt

derekxu16 · 2026-03-04T19:28:50Z

I’m using fixup commits to make this easier to review. I’ll squash them with git rebase --autosquash and reupload once this PR is approved.

...compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/analysis/Stability.kt

ShikaSD · 2026-03-13T18:56:59Z

Could you please attach Relnote to the corresponding commits? The release notes script will pick up those automatically, and we definitely want to surface these changes.

.../src/jvmTest/kotlin/androidx/compose/compiler/plugins/kotlin/ClassStabilityTransformTests.kt

...tests/src/jvmTest/kotlin/androidx/compose/compiler/plugins/kotlin/ComposeCrossModuleTests.kt

.../src/jvmTest/kotlin/androidx/compose/compiler/plugins/kotlin/ClassStabilityTransformTests.kt

....compiler.plugins.kotlin.ClassStabilityTransformTests/testComposableCall[useFir = false].txt

...compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/analysis/Stability.kt

...expect for those explicitly marked as known stable Relnote: "Started inferring the stability of all interfaces to be `Stability.Unknown`, expect for those explicitly marked as known stable."

...compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/analysis/Stability.kt

New changes affect files owned by this reviewer. Re-review required.

ShikaSD · 2026-03-25T00:21:58Z

cc @Tapchicoma to approve integration tests

Tapchicoma · 2026-03-25T14:42:07Z

...lin-gradle-plugin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/ComposeIT.kt

If you want to run the test with the latest max supported Gradle version - just use @GradleTestVersions(minVersion = TestVersions.Gradle.MAX_SUPPORTED

The second build performed in this test uses a constant Kotlin version of 2.3.10

kotlin/libraries/tools/kotlin-gradle-plugin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/ComposeIT.kt

Line 912 in 254c7f0

buildOptions = defaultBuildOptions.copy(androidVersion = agpVersion, kotlinVersion = "2.3.10"),

so if I use TestVersions.Gradle.MAX_SUPPORTED, I think this test could unexpectedly break if TestVersions.Gradle.MAX_SUPPORTED becomes incompatible with Kotlin 2.3.10.

...lin-gradle-plugin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/ComposeIT.kt

Tapchicoma

It would be nice to update test

Relnote: "Started using `Stability.Runtime` more broadly. Now, when an element depends on the stability of an `internal` or `public` class defined in another file, the element will no longer infer the stability of that class and will depend on the runtime stability of that class instead." Bug: 427530633

On JVM, there is now different logic governing when runtime stability is used, so the code reading the known stable bit of stability bitmasks has become unreachable. On other platforms, the code reading that bit is also unreachable, because when the stability of a module is analyzed, any declarations encountered with origin `IR_EXTERNAL_DECLARATION_STUB` are guaranteed to be from a different module.

…tComposeLowering` This CL makes it so that a getter call is inferred as static only when it is an invocation of a default getter of a read-only property, and the call is made in the same file that the property is defined in. Bug: 427530633

New changes affect files owned by this reviewer. Re-review required.

derekxu16 force-pushed the prr/derekx/start-using-runtime-stability-more-broadly branch from c677b4d to 1f499e0 Compare February 27, 2026 18:26

derekxu16 commented Feb 27, 2026

View reviewed changes

...sted/src/main/java/androidx/compose/compiler/plugins/kotlin/lower/AbstractComposeLowering.kt Outdated Show resolved Hide resolved

derekxu16 marked this pull request as ready for review February 27, 2026 18:29

derekxu16 requested a review from ShikaSD February 27, 2026 18:30

ShikaSD requested changes Mar 3, 2026

View reviewed changes

derekxu16 force-pushed the prr/derekx/start-using-runtime-stability-more-broadly branch from 1f499e0 to c83c4ed Compare March 4, 2026 19:26

ShikaSD reviewed Mar 5, 2026

View reviewed changes

...compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/analysis/Stability.kt Outdated Show resolved Hide resolved

ShikaSD reviewed Mar 5, 2026

View reviewed changes

...compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/analysis/Stability.kt Outdated Show resolved Hide resolved

derekxu16 force-pushed the prr/derekx/start-using-runtime-stability-more-broadly branch from 51816b9 to f5189cc Compare March 9, 2026 18:22

ShikaSD reviewed Mar 13, 2026

View reviewed changes

...compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/analysis/Stability.kt Outdated Show resolved Hide resolved

...compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/analysis/Stability.kt Outdated Show resolved Hide resolved

Infer the stability of all interfaces to be Stability.Unknown

28fb312

...expect for those explicitly marked as known stable Relnote: "Started inferring the stability of all interfaces to be `Stability.Unknown`, expect for those explicitly marked as known stable."

derekxu16 force-pushed the prr/derekx/start-using-runtime-stability-more-broadly branch 2 times, most recently from 87cad39 to a6bedbc Compare March 16, 2026 20:03

ShikaSD reviewed Mar 16, 2026

View reviewed changes

...compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/analysis/Stability.kt Outdated Show resolved Hide resolved

ShikaSD reviewed Mar 16, 2026

View reviewed changes

...compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/analysis/Stability.kt Outdated Show resolved Hide resolved

derekxu16 force-pushed the prr/derekx/start-using-runtime-stability-more-broadly branch from d7162e7 to a8201e6 Compare March 17, 2026 19:08

ShikaSD previously approved these changes Mar 18, 2026

View reviewed changes

...compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/analysis/Stability.kt Show resolved Hide resolved

derekxu16 force-pushed the prr/derekx/start-using-runtime-stability-more-broadly branch from a8201e6 to 622c7e1 Compare March 23, 2026 19:09

derekxu16 force-pushed the prr/derekx/start-using-runtime-stability-more-broadly branch from 622c7e1 to 3c016e2 Compare March 23, 2026 20:45

ShikaSD previously approved these changes Mar 25, 2026

View reviewed changes

derekxu16 requested a review from Tapchicoma March 25, 2026 13:44

Tapchicoma reviewed Mar 25, 2026

View reviewed changes

...lin-gradle-plugin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/ComposeIT.kt Outdated Show resolved Hide resolved

Tapchicoma reviewed Mar 25, 2026

View reviewed changes

...lin-gradle-plugin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/ComposeIT.kt Outdated Show resolved Hide resolved

Tapchicoma reviewed Mar 25, 2026

View reviewed changes

derekxu16 added 4 commits March 25, 2026 15:46

Add a test for the caching behavior of StabilityInferencer

254c7f0

derekxu16 force-pushed the prr/derekx/start-using-runtime-stability-more-broadly branch from 3c016e2 to 254c7f0 Compare March 25, 2026 19:47

Conversation

derekxu16 commented Feb 27, 2026

Uh oh!

kotlin-safe-merge bot commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Owners

Uh oh!

Uh oh!

ShikaSD left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

derekxu16 commented Mar 4, 2026

Uh oh!

Uh oh!

Uh oh!

ShikaSD commented Mar 13, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ShikaSD commented Mar 25, 2026

Uh oh!

Tapchicoma Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

derekxu16 Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Tapchicoma left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kotlin-safe-merge bot commented Feb 27, 2026 •

edited

Loading