add missing contract to StandaloneAnalysisAPISessionBuilder.buildKtModuleProvider#5703
Open
BraisGabin wants to merge 1 commit intoJetBrains:masterfrom
Open
add missing contract to StandaloneAnalysisAPISessionBuilder.buildKtModuleProvider#5703BraisGabin wants to merge 1 commit intoJetBrains:masterfrom
StandaloneAnalysisAPISessionBuilder.buildKtModuleProvider#5703BraisGabin wants to merge 1 commit intoJetBrains:masterfrom
Conversation
…tModuleProvider` `buildStandaloneAnalysisAPISession` has contract and the function that `StandaloneAnalysisAPISessionBuilder.buildKtModuleProvider` delegates its job also has the contract so it have sense to add the contract to this function too. ## Context I'm working on detekt and this will allow us to change a `lateinit var` to a `val`.
Code Owners
|
marcopennekamp
approved these changes
Mar 26, 2026
Contributor
marcopennekamp
left a comment
marcopennekamp
left a comment
There was a problem hiding this comment.
Sorry for the late review! This totally slipped through the cracks.
Thanks for the contribution!
Contributor
|
/safe-merge |
|
Quality gate is triggered at https://buildserver.labs.intellij.net/build/912071791 — use this link to get full insight. Quality gate was triggered with the following revisions:
|
|
Triggered a retry attempt #1 out of 1. |
|
Quality gate failed. See https://buildserver.labs.intellij.net/build/912071791 to get full insight. |
Contributor
|
@BraisGabin Can you rebase on a fresh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buildStandaloneAnalysisAPISession(The way to get an instance ofStandaloneAnalysisAPISessionBuilder) has contract and the function thatStandaloneAnalysisAPISessionBuilder.buildKtModuleProviderdelegates its job also has the contract so it have sense to add the contract tobuildKtModuleProvidertoo.Context
I'm working on detekt and this will allow us to change a
lateinit varto aval.