Skip to content

Fix :edit to create file if it does not exist (VIM-266)#1617

Open
AndDe-gourav wants to merge 3 commits intoJetBrains:masterfrom
AndDe-gourav:fix-vim-266-create-file
Open

Fix :edit to create file if it does not exist (VIM-266)#1617
AndDe-gourav wants to merge 3 commits intoJetBrains:masterfrom
AndDe-gourav:fix-vim-266-create-file

Conversation

@AndDe-gourav
Copy link
Copy Markdown

@AndDe-gourav AndDe-gourav commented Mar 20, 2026

This change makes :edit behave like Vim by creating a new file
when the specified file does not exist.

Previously, :edit returned an error if the file was missing.

Changes:

  • Create file inside project base path if not found
  • Create parent directories when needed
  • Refresh VirtualFileSystem after creation
  • Open created file in editor

@1grzyb1
Copy link
Copy Markdown
Collaborator

1grzyb1 commented Apr 3, 2026

Hi
I don't think we should create files using java.io.File.createNewFile() and mkdirs() as they are blocking I/O on the EDT.
There is VfsUtil.createDirectoryIfMissing built in in platform maybe try with this one.

@AndDe-gourav AndDe-gourav force-pushed the fix-vim-266-create-file branch from 0bb5bc8 to 7d19ef4 Compare April 4, 2026 19:02
@AndDe-gourav
Copy link
Copy Markdown
Author

AndDe-gourav commented Apr 4, 2026

I updated the code which uses the VfsUtil.createDirectoryIfMissing function.

@1grzyb1
Copy link
Copy Markdown
Collaborator

1grzyb1 commented Apr 7, 2026

Did you test that by running IdeaVim with split mode?
Also we should at least add standard tests for this behaviour and for split mode in split-mode-tests

@AndDe-gourav
Copy link
Copy Markdown
Author

AndDe-gourav commented Apr 9, 2026

I tested it but did'nt write tests,
should i write test cases for every single type of uses of command of :e

@1grzyb1
Copy link
Copy Markdown
Collaborator

1grzyb1 commented Apr 15, 2026

It would be useful to have at least one test for that, especially in split-mode tests, as it is easy to break stuff in split-mode scenarios

@AndDe-gourav
Add tests for :edit file creation (VIM-266)
86d2b2b 
# Conflicts:
#	src/test/java/org/jetbrains/plugins/ideavim/ex/implementation/commands/EditFileCreateTest.kt
#	tests/split-mode-tests/src/test/kotlin/com/maddyhome/idea/vim/split/EditFileCreateSplitTest.kt
@AndDe-gourav
Copy link
Copy Markdown
Author

AndDe-gourav commented May 1, 2026

added normal and split mode tests

@AndDe-gourav
Copy link
Copy Markdown
Author

AndDe-gourav commented May 6, 2026

@1grzyb1 does all things are correct now.

@1grzyb1 1grzyb1 enabled auto-merge (rebase) May 6, 2026 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1grzyb1 1grzyb1 1grzyb1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AndDe-gourav @1grzyb1