fix: Suppress benign DWM_E_COMPOSITIONDISABLED error#38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses AUTOMIDIPLAYER-12:
System.Runtime.InteropServices.COMException: {Desktop composition is disabled} The operation could not be completed because desktop composition is disabled. (0x80263001).This COMException occurs when WPF's
WindowChrome(used byFluentWindowfor Mica/extended title bar) attempts to callDwmExtendFrameIntoClientAreawhile Desktop Window Manager (DWM) composition is temporarily disabled. This can happen in scenarios like remote desktop sessions or specific system events.The exception is cosmetic and benign; the window simply won't have the extended glass/Mica frame effect, but the application remains fully functional. Previously, the application's global exception handlers (
OnDispatcherUnhandledException,OnUnhandledException,OnUnobservedTaskException) were treating this as a fatal error, leading to a crash dialog and unnecessary Sentry reports.This fix introduces a helper method
IsBenignDwmCompositionExceptionto identify this specificCOMExceptionby itsHResult(0x80263001). The global exception handlers now:e.Handled = true(for dispatcher exceptions) ore.SetObserved()(for unobserved task exceptions) to prevent the crash dialog.This prevents noisy crash reports and improves user experience by avoiding crash dialogs for a non-critical system state change.
Fixes AUTOMIDIPLAYER-12