deps: Add explicit Microsoft.Extensions.Logging reference#35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The application was encountering a
System.IO.FileNotFoundExceptionforMicrosoft.Extensions.Logging, Version=10.0.0.0during startup, specifically when initializing the Entity Framework CorePlayerContext. This was due to a known issue where transitive NuGet dependencies from project references are not always copied to the build output directory in WPF projects.Microsoft.Extensions.Loggingis a transitive dependency of Entity Framework Core, which is referenced byAutoMidiPlayer.Data. AlthoughAutoMidiPlayer.Datacorrectly references it,AutoMidiPlayer.WPFdid not have a direct reference. This caused MSBuild to omitMicrosoft.Extensions.Logging.dllfrom the final publish output for the WPF project.To resolve this, an explicit
PackageReferenceforMicrosoft.Extensions.Logging(version 10.0.5) has been added to bothAutoMidiPlayer.Data.csprojandAutoMidiPlayer.WPF.csproj. This forces MSBuild to include the necessary DLL in the build output, ensuring the application can find and load the assembly at runtime.Fixes AUTOMIDIPLAYER-P