Use arg variable instead of value.str for setting args->clibs#204
Open
bemxio wants to merge 1 commit intoJamesbarford:mainfrom
Open
Use arg variable instead of value.str for setting args->clibs#204bemxio wants to merge 1 commit intoJamesbarford:mainfrom
arg variable instead of value.str for setting args->clibs#204bemxio wants to merge 1 commit intoJamesbarford:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cliParseNopdoesn't putrawargintoCliValue.str, and with it being empty, the library flags do not get appended to the build command.For whatever reason though, this change makes the compiler SIGABRT, returning
double free or corruption (!prev)happening when freeing an arena block and I don't know enough about region-based memory managment to fix it. It does produce a working executable though.Might also be a good idea to rename it to
-cflags=instead of-clibs=for general usage, though that's just a suggestion.