Use 17 digits of precision with Double.ToString#2823
Open
oleks wants to merge 2 commits intoJamesNK:masterfrom
Open
Use 17 digits of precision with Double.ToString#2823oleks wants to merge 2 commits intoJamesNK:masterfrom
oleks wants to merge 2 commits intoJamesNK:masterfrom
Conversation
Using 15 digits ("R") leads to failure of roundtrip
serialization/deserialization.
See also https://learn.microsoft.com/en-us/dotnet/api/system.double.tostring
Another example is 0.6822871999174
oleks
force-pushed
the
oleks-fix-double-conversion-precision
branch
from
e954f70 to
0796691
Compare
Author
|
I suppose one could make the argument that it is better to parameterize the library by the format that it should use for Hence, it is probably best to let the users choose their poison. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using 15 digits ("R") leads to failure of roundtrip serialization/deserialization.
See also https://learn.microsoft.com/en-us/dotnet/api/system.double.tostring
Another example is 0.6822871999174