Skip to content

feat(terra-draw-google-maps-adapter): allow customization of fullscreen behavior by adapters #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
acorncom wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(terra-draw-google-maps-adapter): allow customization of fullscreen behavior by adapters #732

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions packages/terra-draw-google-maps-adapter/src/terra-draw-google-maps-adapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,9 @@ export class TerraDrawGoogleMapsAdapter extends TerraDrawExtend.TerraDrawBaseAda
const sw = bounds.getSouthWest();
const latLngBounds = new this._lib.LatLngBounds(sw, ne);

// In fullscreen mode, use coordinates relative to the fullscreen element
const mapElement = document.fullscreenElement ?? this._map.getDiv();
const mapCanvasRect = mapElement.getBoundingClientRect();
const mapCanvasRect = this.getBoundingMapElement(
this._map,
).getBoundingClientRect();
const offsetX = event.clientX - mapCanvasRect.left;
const offsetY = event.clientY - mapCanvasRect.top;
const screenCoord = new this._lib.Point(offsetX, offsetY);
Expand All @@ -168,6 +168,21 @@ export class TerraDrawGoogleMapsAdapter extends TerraDrawExtend.TerraDrawBaseAda
}
}

/**
* Returns the containing parent element to do lng/lat calculations from
*
* Defaults here should work well for most use-cases, but in the case of a map loaded by
* a fullscreen parent element (think custom button bar above a full-screen map),
* overrides by a custom adapter become possible
*
* @param map
* @returns
*/
getBoundingMapElement(map: google.maps.Map) {
// In fullscreen mode, use coordinates relative to the fullscreen element
return document.fullscreenElement ?? map.getDiv();
}

/**
* Retrieves the HTML element of the Google Map element that handles interaction events
* @returns The HTMLElement representing the map container.
Expand Down
Loading