Прошу проверить домашнее задание#5
Open
kirillku wants to merge 6 commits intoJSMonk:homework-taskfrom
Open
Conversation
JSMonk
reviewed
Apr 16, 2021
| throw new Error("Not Implemented"); | ||
| constructor(private readonly userService: UserService) {} | ||
|
|
||
| public async login(email: string, password: string): Promise<User> { |
Owner
There was a problem hiding this comment.
У Вас отсутствует какая-либо валидация данных (можно передать пустые строки) (мы не зря указали в комментариях над методом "попробуйте определить типы по-лучше" 😺 )
| // } | ||
|
|
||
| // return [Operation.UPDATE_TO_CLIENT, Operation.UPDATE_TO_ADMIN]; | ||
| getAvailableOperations(user: User, currentUser: User): Operation[] { |
Owner
There was a problem hiding this comment.
Давайте попробуем определить эту логику на типах (как мы делали во время лекции)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@JSMonk
Я там добавил один комментарий на счет синхронизации авторизованного пользователя. Не стал это исправлять, так как пришлось бы много переписать. И не уверен как это сделать чтобы список пользователей был только в сервисе, а не в контексте.