[01112] CodeInput text selection invisible in dark mode#3444
Merged
Conversation
Replace broken ::selection CSS rule with CodeMirror's .cm-selectionBackground selector using var(--primary) at 25% opacity. Add drawSelection() extension to enable CodeMirror's selection rendering layer. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Staging removedStaging environment has been deleted for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Fixed invisible text selection in CodeInput widget in dark mode. Replaced the broken
::selectionCSS rule (which usedvar(--input)— a dark grey in dark mode) with CodeMirror's.cm-selectionBackgroundselector usingvar(--primary)at 25% opacity, visible on both light and dark backgrounds. AddeddrawSelection()extension to enable CodeMirror's own selection rendering layer.API Changes
None.
Files Modified
src/frontend/src/widgets/inputs/code/theme.ts— Replaced::selectionrule with.cm-selectionBackgroundand fallback::selectionusingvar(--primary)at 25% opacitysrc/frontend/src/widgets/inputs/code/CodeInputWidget.tsx— AddeddrawSelectionimport and included it inminimalSetupextensionsCommits