[01105] Require cmd/ctrl+click to open links in DataTable cells#3440
Merged
[01105] Require cmd/ctrl+click to open links in DataTable cells#3440
Conversation
Collaborator
Staging removedStaging environment has been deleted for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Updated
handleCellClickedinuseCellInteractions.tsto require cmd+click (macOS) or ctrl+click (Windows/Linux) before opening link-cell URLs. Previously, plain clicks on link cells would navigate away, conflicting with cell selection. Updated tests to verify the modifier key requirement.API Changes
None. The internal callback signature changed to accept
GridMouseEventArgsas a second parameter, but the public hook API (handleCellClickedreturn value) is unchanged sinceDataEditor'sonCellClickedalready passes both arguments.Files Modified
src/frontend/src/widgets/dataTables/hooks/useCellInteractions.ts— AddedGridMouseEventArgsimport, modifier key check, updated callback signaturesrc/frontend/src/widgets/dataTables/hooks/useCellInteractions.test.ts— Rewrote tests to verify modifier key requirement (9 tests)Commits