[01110] Consistent Tooltip Style in DataTable Row Actions#3438
Merged
[01110] Consistent Tooltip Style in DataTable Row Actions#3438
Conversation
…widget Port the styled Tooltip from the old actionDropdown.tsx into the new widgets/rowAction/ActionDropdown.tsx, replacing the native title attribute. The old file keeps the re-export from @/widgets/rowAction/ActionDropdown. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
Staging removedStaging environment has been deleted for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Replaced the native HTML
titleattribute onActionDropdown'sTriggerButtonwith the styled shadcn/uiTooltipcomponent. This makes dropdown action triggers show the same themed tooltip as regularActionButtoncomponents, ensuring consistent UX across all DataTable row actions.Note: The plan suggested using the
withTooltipHOC, but this doesn't work correctly withDropdownMenuTrigger asChildbecause the HOC wraps the component in aTooltipProvidertree that breaks Radix'sSlotcomposition. Instead, theTooltipcomponents are used directly in the JSX with nestedasChildcomposition (TooltipTrigger asChild > DropdownMenuTrigger asChild > TriggerButton), which correctly composes both Radix primitives.API Changes
None.
Files Modified
src/frontend/src/widgets/dataTables/dataTableRowAction/actionDropdown.tsx— Replaced nativetitlewith styledTooltipcomponentCommits