Fix UriFormatException in OAuth login URL construction#3432
Merged
Conversation
Add two new project entries to TeamIvyConfig for the Ivy Design System (tokens, fonts, shared styles) and Ivy Web (Next.js web app) projects. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…aml conflict Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…add-designsystem-web-tendril-config
…add-designsystem-web-tendril-config
BaseUrl without BasePath returns "http://host:port" with no trailing slash, causing the interpolated URI to be invalid (e.g. "http://localhost:5000ivy/auth/oauth-login"). TrimEnd + explicit slash ensures UriBuilder always receives a valid URI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The config.yaml additions (DesignSystem and Web project entries) were merged in from the add-designsystem-web-tendril-config branch and don't belong in this OAuth URI fix PR. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
Staging removedStaging environment has been deleted for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
System.UriFormatException: Invalid port specifiedinOAuthFlowView.Build()whenBaseUrlhas no trailing slashBaseUrlwithoutBasePathreturnshttp://host:port(no trailing/), so the interpolated string becamehttp://localhost:5000ivy/auth/oauth-login— an invalid URI thatUriBuildercan't parseTrimEnd('/')+ explicit/to ensure a valid URI in all casesTest plan
BaseUrlthat has noBasePath(e.g.http://localhost:5000)BaseUrlthat has aBasePath(trailing slash already present)🤖 Generated with Claude Code