[01089] Fix DataTable row action tooltips to show on hover#2963
Merged
[01089] Fix DataTable row action tooltips to show on hover#2963
Conversation
…ble row actions Use the framework's styled tooltip system instead of the native HTML title attribute for consistent tooltip behavior across the UI. Add tooltip text to sample app row actions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Deploy timed outI'm preparing your docs & samples for this PR. I'll update the comment as Sliplane reports progress. Logs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaced the native HTML
titleattribute with the Ivy Framework'swithTooltipHOC in the DataTable row action button component. This makes row action tooltips appear immediately on hover with styled appearance, matching the behavior of toolbar buttons and other framework components. Added tooltip text to the sample app's row actions.API Changes
None. The existing
Tooltipproperty onMenuItemwas already available; this change only affects how it renders on the frontend.Files Modified
Frontend:
src/frontend/src/widgets/dataTables/dataTableRowAction/actionButton.tsx— Replacedtitle={action.tooltip}withwithTooltipHOC wrapping the button, usingtooltipTextpropSamples:
src/Ivy.Samples.Shared/Apps/Widgets/DataTableApp.cs— Added.Tooltip()calls to Edit, Delete, View, and Menu row actionsCommits
2b8812575