[01484] Dashboard table still not showing data rows#2913
Merged
nielsbosma merged 1 commit intomainfrom Apr 2, 2026
Merged
Conversation
Replace synchronous getBoundingClientRect with a retry loop (up to 5 frames) so DataTables inside nested flex layouts get measured after the layout resolves instead of reading height=0 at mount time.
Collaborator
Deploy timed outI'm preparing your docs & samples for this PR. I'll update the comment as Sliplane reports progress. Logs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the Dashboard DataTable showing only column headers with no data rows. The root cause was that
.Height(Size.Full())relied on flex height resolution, but the DataTable's container had zero height at mount time because it was inside a nested vertical layout with a sibling chart. Also improved the Framework'suseContainerSizehook to retry initial measurement across animation frames instead of failing silently when the container has zero height at mount.Files Modified
src/frontend/src/widgets/dataTables/hooks/useContainerSize.ts— Replaced synchronous initial measurement with a retry loop (up to 5 animation frames) for containers that start with zero dimensionsCommits