[01449] Tooltip should set aria-label on icon-only buttons#2909
Merged
nielsbosma merged 1 commit intomainfrom Apr 2, 2026
Merged
[01449] Tooltip should set aria-label on icon-only buttons#2909nielsbosma merged 1 commit intomainfrom
nielsbosma merged 1 commit intomainfrom
Conversation
Collaborator
Deploy timed outI'm preparing your docs & samples for this PR. I'll update the comment as Sliplane reports progress. Logs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modified the
withTooltipHOC to automatically setaria-labelon wrapped components when a tooltip is present and no explicitaria-labelis already provided. Also updated the explicitTooltipWidgetto extract text content from its Content slot and apply it asaria-labelon the trigger span wrapper.API Changes
withTooltipHOC now passesaria-label={tooltipText}to wrapped components (non-breaking — only adds attribute when tooltip exists and no explicit aria-label is set)TooltipWidgetspan wrapper now includesaria-labelextracted from text content in the Content slotFiles Modified
extractTexthelper and aria-label on trigger spanCommits
95bc9738[01449] Add aria-label to tooltip-wrapped components for accessibility