Switch main theme to shadcn palette, keep ivy green only for branding#2903
Merged
Switch main theme to shadcn palette, keep ivy green only for branding#2903
Conversation
…mary ivy green - only logo and ivt corner branding should have the primary green, but apps in ivy framework should all be based off shadcn color palette
rorychatt
approved these changes
Apr 1, 2026
Collaborator
|
@dcrjodle can we also update theme customizer app? |
Update ThemeCustomizer to support Brand color in clone, color pickers, code generation, and palette preview. Update Colors.md and Theming.md documentation to include Brand in semantic colors list and examples. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
@rorychatt Isn't the brand color supposed to be an internal color, since it's only applied to Ivy elements, and therefore nothing users will ever use? |
rorychatt
requested changes
Apr 2, 2026
Collaborator
rorychatt
left a comment
rorychatt
left a comment
There was a problem hiding this comment.
rename brand into Ivy green
Rename Brand/BrandForeground to IvyGreen/IvyGreenForeground across the codebase. This color is reserved for internal Ivy branding elements (logo, "Made with Ivy" corner) and is not user-customizable, so it is removed from ThemeCustomizer and theme configuration examples in docs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
DeletedStaging services have been deleted. |
rorychatt
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan