[01360] Sheet animation should slide from direction instead of dialog-style scale#2900
Merged
nielsbosma merged 1 commit intomainfrom Apr 1, 2026
Merged
[01360] Sheet animation should slide from direction instead of dialog-style scale#2900nielsbosma merged 1 commit intomainfrom
nielsbosma merged 1 commit intomainfrom
Conversation
Replace broken [data-radix-dialog-content] CSS selectors with [data-sheet-side] which is actually set on the SheetContent element. Remove alert-animate-enter class, unused overlay animation CSS, and unused .sheet-animate-enter/.sheet-animate-exit classes.
Collaborator
Deploy timed outI'm preparing your docs & samples for this PR. I'll update the comment as Sliplane reports progress. Logs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed sheet directional slide animations that were completely broken due to CSS selectors targeting
[data-radix-dialog-content], an attribute not set by Radix UI v1.1.15. Replaced all selectors with[data-sheet-side]which is already set on the SheetContent element. Also removed thealert-animate-enterclass from SheetWidget and deleted unused.sheet-animate-enter/.sheet-animate-exitutility classes and overlay animation selectors.API Changes
None.
Files Modified
[data-radix-dialog-content]selectors with[data-sheet-side]selectors, removed overlay animation selectors and unused utility classesalert-animate-enterfrom classNameCommits
Artifacts
Screenshots