[01356] Fix code block rendering without language specifier#2898
Merged
nielsbosma merged 1 commit intomainfrom Apr 1, 2026
Merged
[01356] Fix code block rendering without language specifier#2898nielsbosma merged 1 commit intomainfrom
nielsbosma merged 1 commit intomainfrom
Conversation
Use node.parent.tagName to detect block-level code elements instead of relying on className. Fenced code blocks without a language are wrapped in <pre> by react-markdown but have no className, causing them to be incorrectly treated as inline code. Also remove the match guard in CodeBlock so no-language blocks reach the SyntaxHighlighter path, with a fallback language of "text".
Collaborator
Deploy timed outI'm preparing your docs & samples for this PR. I'll update the comment as Sliplane reports progress. Logs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixed fenced code blocks without a language specifier rendering as inline code instead of block-level code elements. The root cause was that
MarkdownRenderer.tsxused!classNameto detect inline code, but react-markdown doesn't set a className on code elements without a language — causing fenced blocks to be misidentified as inline. Fixed by checking the AST parent node (node.parent.tagName === 'pre'). Also removed thematchguard inCodeBlock.tsxso no-language blocks reach the SyntaxHighlighter with a fallback language of"text".API Changes
None.
Files Modified
match &&guard and added"text"language fallbackCommits
Artifacts
Screenshots