[01295] Ghost variant for DataTable (no edges, no padding)#2896
Open
nielsbosma wants to merge 6 commits intomainfrom
Open
[01295] Ghost variant for DataTable (no edges, no padding)#2896nielsbosma wants to merge 6 commits intomainfrom
nielsbosma wants to merge 6 commits intomainfrom
Conversation
Collaborator
DeployedDocs: https://ivy-staging-docs-2896.sliplane.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added a
Ghostvariant to DataTable that removes the container border, border-radius, horizontal grid borders, and footer border. This allows seamless embedding of a DataTable inside containers likeCardwith zero padding. A sample appDataTableGhostAppdemonstrates the ghost variant alongside the default for comparison.API Changes
DataTableVariant(Default,Ghost) inIvynamespaceDataTable.Variant(defaults toDataTableVariant.Default)DataTable.Variant(DataTableVariant variant)DataTable.Ghost()(shorthand forVariant(DataTableVariant.Ghost))Files Modified
Backend:
src/Ivy/Widgets/DataTables/DataTable.cs— Added enum, prop, and extension methodsFrontend:
src/frontend/src/widgets/dataTables/types/types.ts— AddedvarianttoTablePropssrc/frontend/src/widgets/dataTables/styles/style.ts— Added ghost container and footer stylessrc/frontend/src/widgets/dataTables/DataTableWidget.tsx— Thread variant to editorsrc/frontend/src/widgets/dataTables/dataTableEditor/DataTableEditor.tsx— Thread variant to GridContainer, useTableTheme, and AggregateFootersrc/frontend/src/widgets/dataTables/components/GridContainer.tsx— Select ghost/default container styles based on variantsrc/frontend/src/widgets/dataTables/hooks/useTableTheme.ts— SethorizontalBorderColorto transparent in ghost modesrc/frontend/src/widgets/dataTables/DataTableFooter.tsx— Ghost footer with no top borderSample:
src/Ivy.Samples.Shared/Apps/Widgets/DataTableGhostApp.cs— Demo app with ghost-in-card and default comparisonCommits
067626c9— [01295] Add Ghost variant for DataTable (no edges, no padding)a3ade27d— [01295] Fix missing using for RelatedToAttribute8d8ae775— [01295] Thread Ghost variant through DataTableBuilder and DataTableViewb8a73599— [01295] Fix sample app - Card does not have Padding method