[01321] Add backwards compatibility for ?chrome=false URL parameter#2895
Merged
nielsbosma merged 3 commits intomainfrom Apr 1, 2026
Merged
[01321] Add backwards compatibility for ?chrome=false URL parameter#2895nielsbosma merged 3 commits intomainfrom
nielsbosma merged 3 commits intomainfrom
Conversation
Support both ?shell=false and ?chrome=false to bypass the AppShell. The shell parameter takes precedence when both are present.
Collaborator
Deploy timed outI'm preparing your docs & samples for this PR. I'll update the comment as Sliplane reports progress. Logs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added backwards compatibility for the
?chrome=falseURL parameter so it works identically to?shell=falsefor bypassing the AppShell. Theshellparameter takes precedence when both are present. Changes span backend (C#) and frontend (TypeScript).API Changes
AppRouter.GetAppShell()changed fromprivate statictointernal staticto enable unit testingAppRouter.GetAppShell()now checks forchromequery parameter as fallback whenshellis absentAppHub.ReservedQueryParamsnow includes"chrome"to prevent it from being passed as app argsgetShellParam()inutils.tsnow checkschromequery parameter as fallback whenshellis absentFiles Modified
src/Ivy/Core/Apps/AppRouter.cs- Added chrome parameter fallback inGetAppShell()src/Ivy/Core/Server/AppHub.cs- Added "chrome" to reserved query paramssrc/frontend/src/lib/utils.ts- UpdatedgetShellParam()to check chrome parametersrc/Ivy/Ivy.csproj- AddedInternalsVisibleToforIvy.Testssrc/Ivy.Tests/Ivy.Tests.csproj- Added ASP.NET Core framework referencesrc/Ivy.Tests/Core/Apps/AppRouterTests.cs- New test class with 8 test casessrc/frontend/src/lib/utils.test.ts- Added 9 test cases forgetShellParam()Commits
9a0f3b97[01321] Add backwards compatibility for ?chrome=false URL parameter43c70ed9[01321] Add tests for chrome/shell URL parameter backwards compatibility1d1991f1[01321] Move AppRouter tests to Ivy.Test project (has InternalsVisibleTo access)