[01255] Add Badge(string) extension method for Button widget#2892
Merged
nielsbosma merged 1 commit intomainfrom Mar 31, 2026
Merged
[01255] Add Badge(string) extension method for Button widget#2892nielsbosma merged 1 commit intomainfrom
nielsbosma merged 1 commit intomainfrom
Conversation
Change Badge component variant from secondary to outline for a bordered appearance with transparent background, as requested in review. Add ButtonBadgeTests for Badge property and Badge+ShortcutKey coexistence.
Collaborator
Deploy timed outI'm preparing your docs & samples for this PR. I'll update the comment as Sliplane reports progress. Logs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changed the Button widget's Badge component from the
secondaryvariant to theoutlinevariant, giving badges a bordered appearance with transparent background instead of a filled secondary color. This was a review-requested styling change. Added unit tests for the Badge extension method.API Changes
None. The backend
Badgeproperty andBadge()extension method remain unchanged.Files Modified
src/frontend/src/widgets/button/ButtonWidget.tsx— changed Badge variant fromsecondarytooutlinesrc/Ivy.Test/ButtonBadgeTests.cs— new test class with 3 tests for Badge property, Badge+ShortcutKey coexistence, and null clearingCommits
Artifacts
Screenshots