[01276] Use Image overlay for Review artifact screenshots#2890
Merged
nielsbosma merged 1 commit intomainfrom Mar 31, 2026
Merged
[01276] Use Image overlay for Review artifact screenshots#2890nielsbosma merged 1 commit intomainfrom
nielsbosma merged 1 commit intomainfrom
Conversation
nielsbosma
force-pushed
the
plan-01276-Ivy-Framework
branch
from
5eb96c7 to
71cd7f1
Compare
Collaborator
Deploy timed outI'm preparing your docs & samples for this PR. I'll update the comment as Sliplane reports progress. Logs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added an
Overlayproperty to the Ivy FrameworkImagewidget that shows a full-screen lightbox overlay when clicked, reusing the existingImageOverlaycomponent. Updated the Tendril Review app to useOverlay = trueon screenshot thumbnails instead of opening a Sheet side panel, providing a better UX for viewing images.API Changes
Image.Overlay(bool, defaultfalse) — new property onIvy.Imagewidget. Whentrue, clicking the image opens a full-screen lightbox overlay instead of firingOnClick.ImageWidgetfrontend: newoverlayprop (boolean, defaultfalse), addscursor: zoom-instyle and rendersImageOverlaycomponent on click.Commits