Improve macOS UI: dark mode support, tooltip fix, and ET-2760 alias#90
Open
nholzmann wants to merge 4 commits into
Open
Improve macOS UI: dark mode support, tooltip fix, and ET-2760 alias#90nholzmann wants to merge 4 commits into
nholzmann wants to merge 4 commits into
Conversation
- Add foreground="black" to tooltip label for visibility on dark backgrounds - Add ET-2760 as alias for ET-2750 (same EcoTank series, compatible config)
- Add is_dark_mode() function to detect system appearance - Add ThemeColors class with light/dark color schemes - Update Treeview heading, tree tags, status text, and help text to use dynamic theme colors for better readability in both modes
- Change default geometry from 500x500 to 750x600 - Standardize minsize to 750x600 across all platforms - Fix "Web interface" capitalization to "Web Interface" 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Replace deprecated trace('w', ...) with trace_add('write', ...) to fix
crash on macOS with newer Homebrew Python that uses Tcl/Tk 9.0.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
ui.pyis_dark_mode()function to detect macOS dark mode viadefaults read -g AppleInterfaceStyleThemeColorsclass with light/dark color schemes that auto-updateforeground="black"for dark mode readabilityepson_print_conf.pyKnown Limitations
Button text may appear clipped on macOS due to the native Aqua ttk theme ignoring padding and height styling. This is a known limitation of ttk on macOS - the Aqua theme enforces native widget appearance and does not respect custom sizing. The increased window size helps mitigate this by giving buttons more horizontal space.
Test Plan
🤖 Generated with Claude Code