chore: release 1.2.0 - #178
Open
mortenboye wants to merge 1 commit into
Open
Conversation
Versions all eight packages at 1.2.0 with the internal constraints, and writes the changelogs for the release: the virtual-device and network session APIs now return futures (#173/#174), and iOS no longer shows the local-network permission prompt at app startup (#175). Minor rather than patch: `addVirtualDevice`, `removeVirtualDevice` and `setNetworkSessionEnabled` changed from `void` to `Future<void>`. Callers that ignore the result are unaffected, but anyone implementing `MidiCommandPlatform` has to widen those overrides. Also fixes the darwin package's `.pubignore`, whose Darwin build-products rule still pointed at the pre-federation `ios/.build/`. With the Swift build output from tool/darwin_native_checks.sh present, the published archive measured 273 MB instead of 18 KB — past pub.dev's 100 MB limit, so a publish from a machine that had run the darwin checks would have failed. A parent .gitignore does not apply to a package in a subdirectory, so the paths are listed in .pubignore. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Versions all eight packages at 1.2.0 with changelogs. Prepared on top of master at c90f5de; #168 is deliberately not included and will land in the next release.
What's in it
addVirtualDevice,removeVirtualDeviceandsetNetworkSessionEnabledreturnFuture<void>(addVirtualDevice drops its Future, so errors surface as unhandled exceptions #173 → fix: return futures from virtual device and network session APIs #174). The platform call was previously discarded, so failures escaped as unhandled asynchronous errors that notry/catchat the call site could see.setNetworkSessionEnabled(true)instead of at plugin init.Why minor, not patch
The three signature changes are source-compatible for callers that ignore the result, but anyone implementing
MidiCommandPlatformmust widen those overrides fromvoid. That is more than a patch communicates, so 1.1.2 → 1.2.0.Also fixed here: a publish blocker
While verifying,
publish:dry-runmeasured the darwin package at 273 MB instead of 18 KB. Its.pubignorestill excluded the pre-federationios/.build/path, so the Swift build output thattool/darwin_native_checks.shnow produces was being packaged. pub.dev's limit is 100 MB, so a publish from any machine that had run the darwin checks would have failed — including the local publish flow this repo uses. The.gitignoreentries added in #176 do not help, because a parent.gitignoredoes not apply to a package in a subdirectory; the paths have to be in.pubignore. Verified: with 252 MB of.buildpresent, the archive is back to 19 KB.Verification
On the committed release branch:
melos bootstrap(9 packages),format:check,analyze,analyze:example,test(6 packages),test:web:chrome,tool/darwin_native_checks.sh(5 Swift tests) andpublish:dry-runall pass — the last reporting 0 warnings for all eight packages.Before publishing
v1.1.2tag — the tag series stops atv1.1.1, so 1.1.2 shipped untagged. Worth creating it retroactively at e1e988c alongsidev1.2.0, otherwise any futuremelos versionrun computes its commit range fromv1.1.1.^1.2.0constraints are not on pub.dev yet:flutter_midi_command_platform_interfacefirst, then the six implementation packages, thenflutter_midi_command.