fix: let terminal review inspect declared artifacts#29
Draft
apodgaiko wants to merge 4 commits into
Draft
Conversation
apodgaiko
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a narrow deliverable_roots option to end_mission so independent terminal review can inspect exact final artifacts outside the normal workspace. Declared roots are resolved, persisted, revalidated before dispatch, rejected when broad or history-bearing, checked for escaping symlinks and control characters, and rendered as data in the reviewer prompt.
This intentionally excludes the earlier fingerprint, force-retry, telemetry, and runtime-identity proposals; those need separate designs and validation.
Verification: 204 passed, 7 skipped; Ruff clean; mypy clean.