Skip to content

fix: grow music inventory dynamically#4583

Merged
NotMyFault merged 1 commit intomainfrom
fix/4567
Jan 26, 2025
Merged

fix: grow music inventory dynamically#4583
NotMyFault merged 1 commit intomainfrom
fix/4567

Conversation

@PierreSchwang
Copy link
Member

Overview

Fixes #4567

Description

not tested, should work (i did test the math part though)

### Submitter Checklist
- [x] Make sure you are opening from a topic branch (**/feature/fix/docs/ branch** (right side)) and not your main branch.
- [x] Ensure that the pull request title represents the desired changelog entry.
- [x] New public fields and methods are annotated with `@since TODO`.
- [x] I read and followed the [contribution guidelines](https://github.com/IntellectualSites/.github/blob/main/CONTRIBUTING.md).

@PierreSchwang PierreSchwang requested a review from a team as a code owner January 25, 2025 20:35
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Jan 25, 2025
@NotMyFault NotMyFault requested a review from a team January 25, 2025 20:36
Copy link
Member

@SirYwell SirYwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If we update to Java 21, we can also use Math.ceilDiv there

@NotMyFault NotMyFault merged commit 974c639 into main Jan 26, 2025
8 checks passed
@NotMyFault NotMyFault deleted the fix/4567 branch January 26, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix This PR fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ArrayIndexOutOfBounds exception happening with /p music

3 participants