-
Notifications
You must be signed in to change notification settings - Fork 26
Update broadcast_arrays to return a tuple instead of a list
#2944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
f0b0144
5e8ba63
2af8b5d
826ee78
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -289,7 +289,7 @@ def test_incompatible_shapes_raise_valueerror(self, shapes): | |
| self.assert_broadcast_arrays_raise(input_shapes[::-1]) | ||
|
|
||
| def test_broadcast_arrays_empty_input(self): | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missed to update |
||
| assert dpnp.broadcast_arrays() == [] | ||
| assert dpnp.broadcast_arrays() == () | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Seems we don't have an explicit type assertion in any tensor or dpnp tests, excluding use case with empty input. |
||
|
|
||
| def test_subok_error(self): | ||
| x = dpnp.ones(4) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by
NumPy 2.x? Is it known where it will be done? NumPy 2.5? Then should explicitly state that.