feat: edit constellations #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements constellation editing functionality for the SkyCultureMaker plugin. The feature allows users to edit existing constellations by opening a new "Edit" dialog that preserves artwork anchors and constellation lines while enabling modifications.
Key changes include:
- Added "Edit" button and functionality to the constellation management UI
- Refactored image anchor classes with improved naming (ScmImageAnchor → ScmConstellationImageAnchor)
- Enhanced constellation dialog to support loading existing constellation data
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| scmSkyCultureDialog.ui | Added Edit button and updated UI layout for constellation management |
| ScmSkyCultureDialog.hpp/cpp | Added edit constellation functionality and button state management |
| ScmConstellationImageAnchor.hpp/cpp | Renamed and refactored image anchor class with improved star binding |
| ScmConstellationImage.hpp/cpp | Renamed and enhanced constellation image class with artwork loading |
| ScmConstellationDialog.hpp/cpp | Added constellation loading and editing capabilities |
| SkyCultureMaker.hpp/cpp | Added constellation dialog opening method |
| ScmDraw.hpp/cpp | Added line loading functionality for editing mode |
| ScmConstellation.hpp/cpp | Added getters for constellation data and hide/show functionality |
| CMakeLists.txt | Updated build configuration for renamed files |
RivinHD
approved these changes
Aug 14, 2025
Integer-Ctrl
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.