Open
Conversation
Enabled the 'truncated' method in the calib function and implemented the inverseDistanceTruncated function. Also updated convergence handling in calibAlgorithm to return the ratio g when max iterations are reached.
Uncommented and enabled the 'truncated' calibration branch and implemented inverseDistanceTruncated. The new function validates that bounds is a length-2 vector, computes truncated distances and their derivative (returns list(distance, fprim)), and errors with a clear message if bounds are missing or malformed. Also re-enabled previously commented convergence warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cette fonction était en attente sur le code initiale avec un TODO. Je me suis permis de l'ajouter, basé sur le code source de calmar, et testé avec succès à Statbel.