Skip to content

Code cleaning : Remove campaignId (except LunaticJsonRawData) #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexisszmundy wants to merge 93 commits into
base: main
Choose a base branch
from

Merge branch 'main' into removeCampaignId

4eedfb8
Select commit
Loading
Failed to load commit list.
Open

Code cleaning : Remove campaignId (except LunaticJsonRawData) #437

Merge branch 'main' into removeCampaignId
4eedfb8
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Apr 16, 2026 in 31s

Quality Gate passed

Issues
22 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 79 in src/main/java/fr/insee/genesis/infrastructure/adapter/DataProcessingContextMongoAdapter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=InseeFr_genesis-api&issues=AZ0vd2eeHCNUh2gxL_8j&open=AZ0vd2eeHCNUh2gxL_8j&pullRequest=437

Check warning on line 385 in src/test/java/fr/insee/genesis/controller/rest/responses/ResponseControllerIT.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Take the required action to fix the issue indicated by this comment. 

See more on https://sonarcloud.io/project/issues?id=InseeFr_genesis-api&issues=AZ0vd2gRHCNUh2gxL_8o&open=AZ0vd2gRHCNUh2gxL_8o&pullRequest=437

Check warning on line 365 in src/test/java/fr/insee/genesis/domain/service/rawdata/LunaticJsonRawDataServiceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=InseeFr_genesis-api&issues=AZ0vd2faHCNUh2gxL_8k&open=AZ0vd2faHCNUh2gxL_8k&pullRequest=437

Check warning on line 311 in src/test/java/fr/insee/genesis/controller/rest/responses/ResponseControllerIT.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=InseeFr_genesis-api&issues=AZ0vd2gRHCNUh2gxL_8n&open=AZ0vd2gRHCNUh2gxL_8n&pullRequest=437

Check warning on line 293 in src/main/java/fr/insee/genesis/domain/service/context/DataProcessingContextService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=InseeFr_genesis-api&issues=AZ0vd2XOHCNUh2gxL_8U&open=AZ0vd2XOHCNUh2gxL_8U&pullRequest=437

Check warning on line 141 in src/test/java/fr/insee/genesis/domain/service/contextualvariable/ContextualVariableJsonServiceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce the number of assertions from 31 to less than 25. 

See more on https://sonarcloud.io/project/issues?id=InseeFr_genesis-api&issues=AZ0vd2fpHCNUh2gxL_8l&open=AZ0vd2fpHCNUh2gxL_8l&pullRequest=437

Check warning on line 86 in src/main/java/fr/insee/genesis/controller/rest/responses/InterrogationController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=InseeFr_genesis-api&issues=AZ0vd2ZsHCNUh2gxL_8d&open=AZ0vd2ZsHCNUh2gxL_8d&pullRequest=437

Check warning on line 219 in src/test/java/fr/insee/genesis/controller/rest/DataProcessingContextControllerIT.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=InseeFr_genesis-api&issues=AZ0vtUz2OTMil6mNeqyr&open=AZ0vtUz2OTMil6mNeqyr&pullRequest=437

Check warning on line 102 in src/main/java/fr/insee/genesis/domain/service/metadata/QuestionnaireMetadataService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=InseeFr_genesis-api&issues=AZ0vd2Y-HCNUh2gxL_8a&open=AZ0vd2Y-HCNUh2gxL_8a&pullRequest=437

Check warning on line 94 in src/main/java/fr/insee/genesis/controller/rest/responses/RawResponseController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=InseeFr_genesis-api&issues=AZ0vd2aVHCNUh2gxL_8e&open=AZ0vd2aVHCNUh2gxL_8e&pullRequest=437

Check warning on line 247 in src/test/java/fr/insee/genesis/controller/rest/DataProcessingContextControllerIT.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=InseeFr_genesis-api&issues=AZ0vd2hPHCNUh2gxL_8u&open=AZ0vd2hPHCNUh2gxL_8u&pullRequest=437

Check warning on line 18 in src/main/java/fr/insee/genesis/domain/service/rawdata/CombinedRawDataService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=InseeFr_genesis-api&issues=AZ0vd2YEHCNUh2gxL_8Y&open=AZ0vd2YEHCNUh2gxL_8Y&pullRequest=437

Check warning on line 928 in src/test/java/fr/insee/genesis/controller/rest/responses/RawResponseControllerIT.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=InseeFr_genesis-api&issues=AZ0vd2f_HCNUh2gxL_8m&open=AZ0vd2f_HCNUh2gxL_8m&pullRequest=437

Check warning on line 440 in src/main/java/fr/insee/genesis/controller/rest/responses/ResponseController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=InseeFr_genesis-api&issues=AZ0vd2ayHCNUh2gxL_8g&open=AZ0vd2ayHCNUh2gxL_8g&pullRequest=437

Check warning on line 16 in src/main/java/fr/insee/genesis/infrastructure/repository/RawResponseInputRepository.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=InseeFr_genesis-api&issues=AZ0vd2d-HCNUh2gxL_8i&open=AZ0vd2d-HCNUh2gxL_8i&pullRequest=437

Check warning on line 48 in src/main/java/fr/insee/genesis/controller/rest/responses/ModeController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This block of commented-out lines of code should be removed. 

See more on https://sonarcloud.io/project/issues?id=InseeFr_genesis-api&issues=AZ0vd2ZZHCNUh2gxL_8b&open=AZ0vd2ZZHCNUh2gxL_8b&pullRequest=437

Check warning on line 266 in src/main/java/fr/insee/genesis/controller/rest/responses/ResponseController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=InseeFr_genesis-api&issues=AZ0vd2ayHCNUh2gxL_8f&open=AZ0vd2ayHCNUh2gxL_8f&pullRequest=437

Check warning on line 232 in src/main/java/fr/insee/genesis/domain/service/rawdata/RawResponseService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "ignored" with an unnamed pattern. 

See more on https://sonarcloud.io/project/issues?id=InseeFr_genesis-api&issues=AZ0vd2XwHCNUh2gxL_8W&open=AZ0vd2XwHCNUh2gxL_8W&pullRequest=437

Check warning on line 317 in src/main/java/fr/insee/genesis/domain/service/context/DataProcessingContextService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=InseeFr_genesis-api&issues=AZ0vd2XOHCNUh2gxL_8V&open=AZ0vd2XOHCNUh2gxL_8V&pullRequest=437

Check warning on line 44 in src/main/java/fr/insee/genesis/controller/rest/responses/ModeController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=InseeFr_genesis-api&issues=AZ0vd2ZZHCNUh2gxL_8c&open=AZ0vd2ZZHCNUh2gxL_8c&pullRequest=437

Check warning on line 201 in src/test/java/fr/insee/genesis/controller/rest/DataProcessingContextControllerIT.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=InseeFr_genesis-api&issues=AZ0vd2hPHCNUh2gxL_8t&open=AZ0vd2hPHCNUh2gxL_8t&pullRequest=437

Check warning on line 281 in src/main/java/fr/insee/genesis/domain/service/context/DataProcessingContextService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "e" with an unnamed pattern. 

See more on https://sonarcloud.io/project/issues?id=InseeFr_genesis-api&issues=AZ2QweKcWbCmbFurwY0H&open=AZ2QweKcWbCmbFurwY0H&pullRequest=437
View more details on SonarQubeCloud