refactor(linux-v4): appserver to enable old comm server on all platforms#1853
refactor(linux-v4): appserver to enable old comm server on all platforms#1853R-Gld wants to merge 3 commits intolinux-v4/mainfrom
Conversation
R-Gld
requested review from
herve-er
and removed request for
a team and
ClementKunz
There was a problem hiding this comment.
Pull request overview
This PR adjusts the IPC layer to (1) always enable the legacy (“old”) comm server in the server process and (2) align the ERROR_INFOLIST request between the Linux v4 frontend and the server by introducing and using a shared "limit" parameter key.
Changes:
- Always enable
OldCommServerviaAppServer::useOldCommServer()across platforms. - Add a shared IPC parameter key
msgParamLimitand use it in the serverErrorInfolistJob. - Update Linux v4
CommService::requestErrorInfoList()to send a boundedlimitwhen requesting error info.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/server/comm/guijobs/errorinfolistjob.cpp | Switches input param key to shared msgParamLimit; keeps output key as a local literal. |
| src/server/appserver.h | Forces useOldCommServer() to always return true (legacy IPC enabled everywhere). |
| src/libcommon/comm.h | Adds shared IPC parameter key msgParamLimit. |
| src/gui4/linux/app/services/commservice.cpp | Sends limit parameter for ERROR_INFOLIST requests (bounded to 1000). |
| // Output parameters keys | ||
| static const auto outParamsErrorInfo = "errorInfoList"; | ||
|
|
There was a problem hiding this comment.
outParamsErrorInfo duplicates the shared IPC key already defined in libcommon/comm.h (msgParamErrorInfoList). Since this job now relies on shared keys for input (msgParamLimit), consider using the shared constant for the output key as well to avoid drift between client/server protocol strings.
There was a problem hiding this comment.
@copilot apply changes based on this feedback
There was a problem hiding this comment.
Done in commit 630c370. Removed the local outParamsErrorInfo literal and replaced it with the shared msgParamErrorInfoList constant from libcommon/comm.h, which already has the same "errorInfoList" value. The Linux v4 client was already reading the response using msgParamErrorInfoList, so both sides now rely on the same shared constant.
…olistJob output Agent-Logs-Url: https://github.com/Infomaniak/desktop-kDrive/sessions/e116e3f6-6e8f-4cf6-9704-fedff232178b Co-authored-by: R-Gld <29811769+R-Gld@users.noreply.github.com>
|
No description provided.