Conversation
Replaced "%@" with "{0}" as the placeholder for splitting localized strings in SystemErrorSyncDirAccessErrorDialog.xaml.cs. This change aligns placeholder usage with .NET conventions and improves maintainability for dynamic text insertion.
Multilingual resource strings updated for offline sync descriptions. Added "releaseChannelTest" entry in all supported languages. Export dates refreshed.
|
There was a problem hiding this comment.
Pull request overview
This PR fixes a WinUI localization placeholder mismatch and refreshes a small set of localized strings in the Windows v4 GUI resources.
Changes:
- Update
SystemErrorSyncDirAccessErrorDialogto split localized sentences on the .NET placeholder ({0}) instead of the macOS-style placeholder (%@). - Adjust the “Available offline” vs “Offline status” description strings across the 5 supported WinUI locales.
- Add a new
releaseChannelTestlocalized string entry in each locale.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/gui4/windows/kDrive client/kDrive client/Strings/it-IT/Resources.resw | Update offline-related descriptions; add releaseChannelTest. |
| src/gui4/windows/kDrive client/kDrive client/Strings/fr-FR/Resources.resw | Update offline-related descriptions; add releaseChannelTest. |
| src/gui4/windows/kDrive client/kDrive client/Strings/es-ES/Resources.resw | Update offline-related descriptions; add releaseChannelTest (note: tone inconsistency introduced). |
| src/gui4/windows/kDrive client/kDrive client/Strings/en-US/Resources.resw | Update offline-related descriptions; add releaseChannelTest. |
| src/gui4/windows/kDrive client/kDrive client/Strings/de-DE/Resources.resw | Update offline-related descriptions; add releaseChannelTest (note: tone inconsistency introduced). |
| src/gui4/windows/kDrive client/kDrive client/CustomControls/Errors/Dialogs/SystemErrorSyncDirAccessErrorDialog.xaml.cs | Fix placeholder split logic to match WinUI Localizer output ({0}). |
| <value>Deine lokalen Dateien bleiben zugänglich. | ||
| Die Synchronisierung wird automatisch fortgesetzt, sobald du wieder verbunden bist.</value> |
There was a problem hiding this comment.
The updated German offline description switches from the app’s generally formal address ("Sie/Ihre") to informal ("Deine/du"). This makes the UI tone inconsistent within the same locale; please keep the wording consistently formal (or consistently informal) across the German strings.
| <value>Deine lokalen Dateien bleiben zugänglich. | |
| Die Synchronisierung wird automatisch fortgesetzt, sobald du wieder verbunden bist.</value> | |
| <value>Ihre lokalen Dateien bleiben zugänglich. | |
| Die Synchronisierung wird automatisch fortgesetzt, sobald Sie wieder verbunden sind.</value> |
| <value>Tus archivos locales siguen siendo accesibles. | ||
| La sincronización se reanudará automáticamente en cuanto vuelvas a estar conectado.</value> |
There was a problem hiding this comment.
The updated Spanish offline description switches from formal address ("su/sus", "vuelva") used throughout the file to informal ("Tus", "vuelvas"). This makes the locale inconsistent; please align this string with the existing formal tone used in the rest of es-ES resources.
| <value>Tus archivos locales siguen siendo accesibles. | |
| La sincronización se reanudará automáticamente en cuanto vuelvas a estar conectado.</value> | |
| <value>Sus archivos locales siguen siendo accesibles. | |
| La sincronización se reanudará automáticamente en cuanto vuelva a estar conectado.</value> |
No description provided.