fix: add autoComplete attribute for Apple 2FA autofill#5377
Open
SaaiAravindhRaja wants to merge 1 commit intoInfisical:mainfrom
Open
fix: add autoComplete attribute for Apple 2FA autofill#5377SaaiAravindhRaja wants to merge 1 commit intoInfisical:mainfrom
SaaiAravindhRaja wants to merge 1 commit intoInfisical:mainfrom
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
Greptile OverviewGreptile SummaryThis PR adds Confidence Score: 5/5
Important Files Changed
|
Author
|
Thank you @maidul98 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1167
Problem
Apple's auto-fill feature fills "I n f i s i" instead of the verification code because the input fields are missing the
autoComplete="one-time-code"attribute.Solution
Added
autoComplete="one-time-code"to allReactCodeInputcomponents in:CodeInputStep.tsx(email verification during signup)Mfa.tsx(MFA code input during login)This tells Apple's autofill system that these fields expect one-time codes from emails/SMS.