fix: clarify bootstrap message when using docker port mapping#5310
Open
MuzzaiyyanHussain wants to merge 1 commit intoInfisical:mainfrom
Open
fix: clarify bootstrap message when using docker port mapping#5310MuzzaiyyanHussain wants to merge 1 commit intoInfisical:mainfrom
MuzzaiyyanHussain wants to merge 1 commit intoInfisical:mainfrom
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
Greptile OverviewGreptile SummaryThis PR adds a clarification note to the bootstrap startup messages to help users understand that when running Infisical in Docker with port mapping, the externally accessible port may differ from the internal container port displayed in the message.
Confidence Score: 5/5
Important Files Changed
|
Contributor
Author
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Clarifies the bootstrap startup messages to avoid misleading port information when running Infisical with Docker port mappings.
Why
When Infisical is run using Docker port mapping (for example
-p 8080:3000or behind a reverse proxy), the bootstrap message displays the container port (appCfg.PORT). This can confuse users because the externally accessible URL may differ, even though Infisical itself works correctly.How
Added a clarification note to the bootstrap messages indicating that the exposed host port may differ when running in Docker, instead of assuming a specific external URL.
Testing
fixes #5295