-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fonts: make fonts part of InfiniTimeTheme #2427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,6 +16,14 @@ namespace Colors { | |
| static constexpr lv_color_t highlight = green; | ||
| }; | ||
|
|
||
| namespace Fonts { | ||
| static constexpr const lv_font_t* normal = &jetbrains_mono_bold_20; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I feel these should be capitalised (I know that disagrees with the entries above) I don't think we have a clear standard for these kind of constants Not something that needs changing to merge. Interested in everyone's opinions on this one, could be totally off base here :)
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I absolutely agree! Even felt weird writing them in lowercase, but I wanted to follow the convention from above.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @JF002 do you have a defined convention in mind? I don't mind too much either way, but we should probably add it to the coding standard |
||
| static constexpr const lv_font_t* mono = &jetbrains_mono_bold_20; | ||
| static constexpr const lv_font_t* large = &jetbrains_mono_42; | ||
| static constexpr const lv_font_t* huge = &jetbrains_mono_76; | ||
| static constexpr const lv_font_t* hugeBold = &jetbrains_mono_extrabold_compressed; | ||
| } | ||
|
|
||
| /** | ||
| * Initialize the default | ||
| * @param color_primary the primary color of the theme | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's the option of something like
static constexpr const lv_font_t &normal = jetbrains_mono_bold_20;to keep the type the same. But maybe it's better as ref anyway?