Skip to content

Change implementation to api in build.gradle.kts so subdependencies are exposed#78

Merged
pbourseau merged 2 commits intoIZIVIA:devfrom
edwardmp:patch-1
Dec 15, 2025
Merged

Change implementation to api in build.gradle.kts so subdependencies are exposed#78
pbourseau merged 2 commits intoIZIVIA:devfrom
edwardmp:patch-1

Conversation

@edwardmp
Copy link
Copy Markdown
Contributor

@edwardmp edwardmp commented Dec 3, 2024

For now I changed all of them to use api, even though for my own use case I don't need all of them to be exposed, but I suspect sooner or later someone else will want to use classes in any of these modules anyway.
Thoughts?

Fixes #54

@edwardmp
Copy link
Copy Markdown
Contributor Author

edwardmp commented Dec 3, 2024

CC @lilgallon

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Dec 3, 2024

@lilgallon
Copy link
Copy Markdown
Member

Thanks for your contribution, I am not sure about exposing ocpp-version specific modules. I will talk with my team about that

@edwardmp
Copy link
Copy Markdown
Contributor Author

edwardmp commented Dec 4, 2024

@lilgallon I'm actually quite sure you need it.
For instance, in the example in the linked issue, you need the com.izivia.ocpp.core16.ChargePointOperations class for the api callbacks, so the ocpp-1-6-core needs to definitely be exposed (same for other verisons)

@sonarqubecloud
Copy link
Copy Markdown

@pbourseau pbourseau merged commit 599b5c6 into IZIVIA:dev Dec 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't use ApiFactory.csmsOcppServer function

3 participants