Relax networkx pin requirement#17
Merged
proccaserra merged 8 commits intoISA-tools:masterfrom May 28, 2025
Merged
Conversation
Libraries should keep pins as lax as possible, see e.g.: https://stackoverflow.com/questions/28509481/should-i-pin-my-python-dependencies-versions
nsoranzo
added a commit
to galaxybot/galaxy
that referenced
this pull request
Jun 30, 2024
nsoranzo
added a commit
to galaxybot/galaxy
that referenced
this pull request
Jun 30, 2024
nsoranzo
added a commit
to galaxybot/galaxy
that referenced
this pull request
Jul 3, 2024
2 tasks
Also: - Drop support for Python 3.8, add support for Python 3.13 . - Remove 2 unused files in `tests/`
Contributor
Author
|
@proccaserra Any chance you can review/merge this PR? Or we (Galaxy Community) would be happy to take care of this package, if that's preferable? |
Contributor
Author
|
@proccaserra Thanks a lot for merging! Could you also make a new 0.10.11 release on GitHub please? I've already bumped the package version as part of this pull request and there's a CI workflow that will upload the sdist and wheel to PyPI. |
|
@proccaserra Thanks for the release! Could you also upload the new version to PyPI when you have a moment? There's a fix in #18. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Libraries should keep pins as lax as possible, see e.g.: https://stackoverflow.com/questions/28509481/should-i-pin-my-python-dependencies-versions
Main reason to open this now is that the currently pinned version (2.5) is not compatible with NumPy 2.0, while the latest releases work fine.
Also:
pyproject.toml.venv/directorySyntaxWarnings