Skip to content

Fix option qhull_options and add option orientation for pvgridder.VoronoiMesh2D.generate_mesh()#50

Merged
keurfonluu merged 3 commits intomainfrom
fix/voronoi
Jan 5, 2026
Merged

Fix option qhull_options and add option orientation for pvgridder.VoronoiMesh2D.generate_mesh()#50
keurfonluu merged 3 commits intomainfrom
fix/voronoi

Conversation

@keurfonluu
Copy link
Copy Markdown
Collaborator

  • Fixed: option qhull_options not passed to internal method. Defaults to None (i.e., Scipy's default).
  • Added: option orientation to ensure consistent orientation of polygon faces (default CCW looking from above, i.e., positive normal).

Reminders:

  • Run invoke ruff to make sure the code follows the style guide,
  • Add tests for new features or tests that would have caught the bug that you're fixing,
  • Write detailed docstrings for all functions, classes and/or methods,
  • If adding new functionality, unit test it and add it to the documentation.

@keurfonluu keurfonluu merged commit 26a6689 into main Jan 5, 2026
10 checks passed
@keurfonluu keurfonluu deleted the fix/voronoi branch January 5, 2026 16:16
@antoinecollet5
Copy link
Copy Markdown
Contributor

@keurfonluu seems ok for me ! Sorry I did not test all cases, and that's a shame that it does not always work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants