Skip to content

SNS - Sensor Bounds Checking from Config#88

Draft
davidbeechey wants to merge 4 commits into
mainfrom
hype-94-read-in-sensor-bounds-from-config-file
Draft

SNS - Sensor Bounds Checking from Config#88
davidbeechey wants to merge 4 commits into
mainfrom
hype-94-read-in-sensor-bounds-from-config-file

Conversation

@davidbeechey

@davidbeechey davidbeechey commented Feb 21, 2025

Copy link
Copy Markdown
Collaborator

Will at some point get this to work. The goal is to (probably) create a macro of some kind that takes in the pod ID and measurement ID for each initialised sensor and uses them to a) validate that the pod ID and measurement ID are valid b) to generate the calculate_bounds function using the limits in the config file.

Not sure whether the sensors themselves need to know their IDs - probably not since the read_* tasks will have logic for sending the resulting messages incl. IDs after reading from the sensors. We could therefore just create the calculate_bounds functions in there anyway? May have just answered my own question there...

Still to do:

  • Support inputting a MeasurementId instead of a string? Easier to find what you want and less error prone
  • default_calculate_bounds functions are repetitive - declarative macro?
  • Make Limit and SensorBound public so they can be used as input to the above macro?

@linear

linear Bot commented Feb 21, 2025

Copy link
Copy Markdown

@davidbeechey davidbeechey marked this pull request as draft February 21, 2025 12:12
@davidbeechey davidbeechey self-assigned this Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant