SNS - ADC Mux#41
Conversation
There was a problem hiding this comment.
Looks good, would be good to have a function for just reading a single channel of the mux. To do so it'd be best to have the channel addresses as an enum, so that'll require modification to the read_data function too.
Edit: actually, it would be really good if we had something like AdcMuxChannel which implemented the HypedAdc trait from PR #41. That would mean we don't need to care whether an ADC sensor is plugged into the ADC on the ST board or into the mux, the sensor can just use anything that implements HypedAdc. It would need to take in a shared I2C instance (using Mutex like in the I2C mux PR #14), the mux address and the channel address.
Co-authored-by: David Beechey <david@dtbeechey.dev>
Co-authored-by: David Beechey <david@dtbeechey.dev> Co-authored-by: platinumxy <83834735+platinumxy@users.noreply.github.com>
Co-authored-by: David Beechey <david@dtbeechey.dev>
Co-authored-by: David Beechey <david@dtbeechey.dev>
H00pyFr00d
requested review from
jpfbastos,
kshxtij and
misha7b
as code owners
Co-authored-by: Michael Belyaev <michael7belyaev@gmail.com>
davidbeechey
left a comment
davidbeechey
left a comment
There was a problem hiding this comment.
Few changes needed + update the comments accordingly
Co-authored-by: David Beechey <david@dtbeechey.dev>
TomLonergan03
left a comment
TomLonergan03
left a comment
There was a problem hiding this comment.
you might need to make some changes in this depending what happens with #49
10 participants
No description provided.