Skip to content

Add simple Rust install deps#21850

Open
MikeMcQuaid wants to merge 1 commit intomainfrom
brew-rs-aview-smoke-test
Open

Add simple Rust install deps#21850
MikeMcQuaid wants to merge 1 commit intomainfrom
brew-rs-aview-smoke-test

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

  • teach install to plan and pour simple runtime dependency trees before linking the requested formula.
  • cover the new path in tests/cli.rs and note the aview smoke test in README.md because libaacs still falls back to Ruby.
  • record that brew fetch aalib aview was needed here while the Rust GHCR downloader still fails on uncached bottles.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests (excluding integration tests) for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

Used OpenAI Codex plus local testing/review.


- teach `install` to plan and pour simple runtime
  dependency trees before linking the requested formula.
- cover the new path in `tests/cli.rs` and note the
  `aview` smoke test in `README.md` because
  `libaacs` still falls back to Ruby.
- record that `brew fetch aalib aview` was needed
  here while the Rust GHCR downloader still fails on
  uncached bottles.
Copilot AI review requested due to automatic review settings March 27, 2026 17:20
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR expands the experimental brew-rs install command to handle “simple” runtime dependency trees (bottle-only, no complex dependency metadata) by planning and pouring dependencies before linking the requested formula, with accompanying test coverage and updated smoke-test documentation.

Changes:

  • Add an install planner to resolve and execute a simple dependency install plan (pour/link actions) instead of requiring a leaf-only bottle.
  • Add a CLI test covering install of a bottle formula with a simple runtime dependency.
  • Document the current real-world smoke test (aview + aalib) and current Rust GHCR download limitations.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
Library/Homebrew/rust/brew-rs/src/commands/install.rs Adds dependency-aware install planning and execution for simple runtime dependency trees.
Library/Homebrew/rust/brew-rs/tests/cli.rs Adds coverage for installing and linking a formula plus a simple runtime dependency.
Library/Homebrew/rust/brew-rs/README.md Documents current install smoke test and notes current downloader behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants