Open
Conversation
- teach `install` to plan and pour simple runtime dependency trees before linking the requested formula. - cover the new path in `tests/cli.rs` and note the `aview` smoke test in `README.md` because `libaacs` still falls back to Ruby. - record that `brew fetch aalib aview` was needed here while the Rust GHCR downloader still fails on uncached bottles.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands the experimental brew-rs install command to handle “simple” runtime dependency trees (bottle-only, no complex dependency metadata) by planning and pouring dependencies before linking the requested formula, with accompanying test coverage and updated smoke-test documentation.
Changes:
- Add an install planner to resolve and execute a simple dependency install plan (pour/link actions) instead of requiring a leaf-only bottle.
- Add a CLI test covering install of a bottle formula with a simple runtime dependency.
- Document the current real-world smoke test (
aview+aalib) and current Rust GHCR download limitations.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Library/Homebrew/rust/brew-rs/src/commands/install.rs | Adds dependency-aware install planning and execution for simple runtime dependency trees. |
| Library/Homebrew/rust/brew-rs/tests/cli.rs | Adds coverage for installing and linking a formula plus a simple runtime dependency. |
| Library/Homebrew/rust/brew-rs/README.md | Documents current install smoke test and notes current downloader behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
installto plan and pour simple runtime dependency trees before linking the requested formula.tests/cli.rsand note theaviewsmoke test inREADME.mdbecauselibaacsstill falls back to Ruby.brew fetch aalib aviewwas needed here while the Rust GHCR downloader still fails on uncached bottles.brew lgtm(style, typechecking and tests) with your changes locally?Used OpenAI Codex plus local testing/review.