Skip to content

feat(memory): wire moraine-mcp as recall tool source, gate legacy pus…#3575

Open
pkeging wants to merge 1 commit into
Hmbown:mainfrom
pkeging:feat/moraine-mcp-recall
Open

feat(memory): wire moraine-mcp as recall tool source, gate legacy pus…#3575
pkeging wants to merge 1 commit into
Hmbown:mainfrom
pkeging:feat/moraine-mcp-recall

Conversation

@pkeging

@pkeging pkeging commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

…h/inject

Item 6: Wire moraine-mcp (stdio MCP server, moraine mcp) as a recall tool source via CodeWhale's default MCP config template so agents gain the Moraine recall tools (searchsessions, open, list_sessions, file_attention).

Item 7: Add [memory] moraine_fallback config gate that deprecates the legacy memory.rs push/inject path (<user_memory> block, remember tool, # foo quick-add) in favor of Moraine pull/recall via MCP.

  • MemoryConfig: add moraine_fallback field + Config accessor
  • EngineConfig: add moraine_fallback bool
  • Gate compose_block at engine.rs:834, :3056
  • Gate compose_block at context_report.rs:205
  • Gate remember tool registration at tool_setup.rs:125
  • Gate #foo quick-add at ui.rs:4609
  • Add moraine-mcp to MCP templates (mcp.rs + main.rs, disabled by default)
  • memory_guidance.md: add Moraine MCP recall guidance section
  • memory.rs: add deprecation notice + migration guide

Summary

Testing

  • cargo fmt --all -- --check
  • cargo clippy --workspace --all-targets --all-features
  • cargo test --workspace --all-features

Checklist

  • Updated docs or comments as needed
  • Added or updated tests where relevant
  • Verified TUI behavior manually if UI changes
  • Harvested/co-authored credit uses a GitHub numeric noreply address

…h/inject

Item 6: Wire moraine-mcp (stdio MCP server, `moraine mcp`) as a recall
tool source via CodeWhale's default MCP config template so agents gain
the Moraine recall tools (searchsessions, open, list_sessions,
file_attention).

Item 7: Add `[memory] moraine_fallback` config gate that deprecates the
legacy memory.rs push/inject path (`<user_memory>` block, `remember`
tool, `# foo` quick-add) in favor of Moraine pull/recall via MCP.

- MemoryConfig: add moraine_fallback field + Config accessor
- EngineConfig: add moraine_fallback bool
- Gate compose_block at engine.rs:834, :3056
- Gate compose_block at context_report.rs:205
- Gate remember tool registration at tool_setup.rs:125
- Gate #foo quick-add at ui.rs:4609
- Add moraine-mcp to MCP templates (mcp.rs + main.rs, disabled by default)
- memory_guidance.md: add Moraine MCP recall guidance section
- memory.rs: add deprecation notice + migration guide
@pkeging pkeging requested a review from Hmbown as a code owner June 25, 2026 05:08
@github-actions

Copy link
Copy Markdown

Thanks @pkeging for taking the time to contribute.

This repository is observing a maintainer-managed PR intake gate in dry-run mode, so this pull request is staying open. This note helps maintainers prepare the allowlist before any enforcement is considered.

Please read CONTRIBUTING.md for the expected contribution shape. A maintainer can grant recurring PR access by commenting /lgtm on a pull request.

@Hmbown

Hmbown commented Jun 25, 2026

Copy link
Copy Markdown
Owner

…h/inject

Item 6: Wire moraine-mcp (stdio MCP server, moraine mcp) as a recall tool source via CodeWhale's default MCP config template so agents gain the Moraine recall tools (searchsessions, open, list_sessions, file_attention).

Item 7: Add [memory] moraine_fallback config gate that deprecates the legacy memory.rs push/inject path (<user_memory> block, remember tool, # foo quick-add) in favor of Moraine pull/recall via MCP.

  • MemoryConfig: add moraine_fallback field + Config accessor

  • EngineConfig: add moraine_fallback bool

  • Gate compose_block at engine.rs:834, :3056

  • Gate compose_block at context_report.rs:205

  • Gate remember tool registration at tool_setup.rs:125

  • Gate #foo quick-add at ui.rs:4609

  • Add moraine-mcp to MCP templates (mcp.rs + main.rs, disabled by default)

  • memory_guidance.md: add Moraine MCP recall guidance section

  • memory.rs: add deprecation notice + migration guide

Summary

Testing

  • cargo fmt --all -- --check

  • cargo clippy --workspace --all-targets --all-features

  • cargo test --workspace --all-features

Checklist

  • Updated docs or comments as needed

  • Added or updated tests where relevant

  • Verified TUI behavior manually if UI changes

  • Harvested/co-authored credit uses a GitHub numeric noreply address

This is great!!! I'm going to hold off on moraine until 66 or 67 so will use this soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants