[codex] Address context window review feedback#3574
Merged
Hmbown merged 1 commit intoJun 25, 2026
Merged
Conversation
Keep route-derived max_tokens positive for tiny configured context windows, and restore the previous provider context-window override when an auth failure rolls back a provider switch. Addresses Codex review threads on crates/tui/src/core/engine/context.rs and crates/tui/src/tui/ui.rs. Validated with: cargo fmt; cargo fmt --all -- --check; cargo test -p codewhale-tui --bin codewhale-tui --locked effective_max_output_tokens_for_route; cargo test -p codewhale-tui --bin codewhale-tui --locked provider_switch_auth_error_restores_previous_provider_and_model; cargo test -p codewhale-tui --bin codewhale-tui --locked; cargo test --workspace --locked; git diff --check.
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Owner
|
Thank you!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #3573 after Codex cloud review found two edge cases:
max_tokenspositive when a configured context window is tiny enough forContextBudgetto clamp output to zeroactive_context_window_overridewhen provider-switch auth rollback restores the previous provider and route limitsThe original provider
context_windowfeature for #3545 was already merged in #3573; this PR carries only the cloud-review fixes that landed locally after that PR was merged.Validation
cargo fmt --all -- --checkcargo test -p codewhale-tui --bin codewhale-tui --locked effective_max_output_tokens_for_routecargo test -p codewhale-tui --bin codewhale-tui --locked provider_switch_auth_error_restores_previous_provider_and_modelcargo test --workspace --lockedgit diff --checkReview feedback addressed
max_tokens