Skip to content

Fix ILU binding API mismatch#106

Merged
greole merged 1 commit intoHelmholtz-AI-Energy:fix/ilu-gko-api-mismatchfrom
2002kaihui:fix/ilu-gko-api-mismatch
May 5, 2026
Merged

Fix ILU binding API mismatch#106
greole merged 1 commit intoHelmholtz-AI-Energy:fix/ilu-gko-api-mismatchfrom
2002kaihui:fix/ilu-gko-api-mismatch

Conversation

@2002kaihui
Copy link
Copy Markdown
Collaborator

@2002kaihui 2002kaihui commented May 5, 2026

Description

Fixes the ILU preconditioner binding to match the updated Ginkgo API.

The previous binding used the old gko::preconditioner::Ilu template interface with explicit lower and upper triangular solver types. The current Ginkgo API expects the template parameters in the form:

gko::preconditioner::Ilu<ValueType, ReverseApply, IndexType>

Type of change

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing tests pass locally with my changes

@yhmtsai yhmtsai requested review from greole, keshvituteja and yhmtsai May 5, 2026 09:37
Copy link
Copy Markdown
Collaborator

@greole greole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM! @yhmtsai We need to merge this into an internal branch first to run the CI. I'll give @2002kaihui access to this repo directly.

@greole greole changed the base branch from main to fix/ilu-gko-api-mismatch May 5, 2026 13:29
@greole greole merged commit 971e9bc into Helmholtz-AI-Energy:fix/ilu-gko-api-mismatch May 5, 2026
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants