Fix ILU binding API mismatch#106
Merged
greole merged 1 commit intoHelmholtz-AI-Energy:fix/ilu-gko-api-mismatchfrom May 5, 2026
Merged
Fix ILU binding API mismatch#106greole merged 1 commit intoHelmholtz-AI-Energy:fix/ilu-gko-api-mismatchfrom
greole merged 1 commit intoHelmholtz-AI-Energy:fix/ilu-gko-api-mismatchfrom
Conversation
greole
reviewed
May 5, 2026
Collaborator
greole
left a comment
There was a problem hiding this comment.
Thank you! LGTM! @yhmtsai We need to merge this into an internal branch first to run the CI. I'll give @2002kaihui access to this repo directly.
971e9bc
into
Helmholtz-AI-Energy:fix/ilu-gko-api-mismatch
4 of 7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the ILU preconditioner binding to match the updated Ginkgo API.
The previous binding used the old
gko::preconditioner::Ilutemplate interface with explicit lower and upper triangular solver types. The current Ginkgo API expects the template parameters in the form:Type of change
Checklist