Made python interface installable via pip#143
Open
AlreadyTakenJonas wants to merge 23 commits intoHarisIqbal88:masterfrom
Open
Made python interface installable via pip#143AlreadyTakenJonas wants to merge 23 commits intoHarisIqbal88:masterfrom
AlreadyTakenJonas wants to merge 23 commits intoHarisIqbal88:masterfrom
Conversation
Author
|
I almost forgot: After installing you can run |
francescosemeraro
approved these changes
Jan 29, 2023
spazm
reviewed
Jun 16, 2024
| @@ -0,0 +1,4 @@ | |||
| #!/usr/bin/env python3 | |||
| # -*- coding: utf-8 -*- | |||
| from .test_simple import main, arch | |||
There was a problem hiding this comment.
These imports conflict. No need to import the individual example namespaces into the top __init__ namespace.
Author
There was a problem hiding this comment.
Thanks! Didn't catch that!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, HarisIqbal88!
My boss told me to use your package for my master thesis and I really like it, but it was bugging me, that it didn't have an installer. So I made it installable via pip. I had to rearrange your directories a little bit, but I hope you like it.
I also added CITATION.cff, this will show how to cite your software directly in the repos sidebar.
You might want to add your email or ORCID in pyproject.toml and check CITATION.cff for errors.
I wish you a happy New Year!
Kind regards,
Jonas Eichhorn