Reject unsupported export extensions - #711
Draft
DJ8520 wants to merge 1 commit into
Draft
Conversation
Owner
|
Let me know when you finish it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
.dwgand.dxfformats..pdffails without creating a mislabeled output file.Why
--export input.dxf output.pdfpreviously fell through to the default DWG writer, exited successfully, and produced DWG bytes under a.pdffilename.Impact
Headless callers now receive a non-zero exit and actionable format guidance instead of silently receiving corrupt-by-contract output. Existing DWG and DXF save paths are unchanged.
Validation
cargo test --release --locked --lib io::save_failure_tests::unsupported_output_extension_is_rejected_before_write -- --exact --nocapture--export ... out.pdfprobe: exit 1, no output file, supported formats named.io::layer_roundtrip_testssuite: 4 passed.