Skip to content

fix: address security and reliability issues found in code review#355

Merged
Haehnchen merged 1 commit intoHaehnchen:masterfrom
abonami:claude/code-review-m2nh4
Feb 27, 2026
Merged

fix: address security and reliability issues found in code review#355
Haehnchen merged 1 commit intoHaehnchen:masterfrom
abonami:claude/code-review-m2nh4

Conversation

@abonami
Copy link

@abonami abonami commented Feb 27, 2026

  • strategy_registry: add isSafeStrategyName() to reject names with path traversal chars; add isPathWithinStrategiesDir() to confine file loads to var/strategies/; remove arbitrary direct-file-path resolution branch
  • bot_runner: attach .catch() handlers to both the initial and recurring onTick() calls so async errors are logged instead of silently swallowed
  • services: fix loose equality (== → ===) for mail port 465 check
  • services: replace console.log with this.getLogger().info() for Telegram missing-token warning so the message goes through the structured logger
  • services: surface config-load errors with console.warn including the file path and error details instead of silently falling back to {}

https://claude.ai/code/session_01MAw1iz4srnJs7oBbqFPwZg

- strategy_registry: add isSafeStrategyName() to reject names with path
  traversal chars; add isPathWithinStrategiesDir() to confine file loads
  to var/strategies/; remove arbitrary direct-file-path resolution branch
- bot_runner: attach .catch() handlers to both the initial and recurring
  onTick() calls so async errors are logged instead of silently swallowed
- services: fix loose equality (== → ===) for mail port 465 check
- services: replace console.log with this.getLogger().info() for Telegram
  missing-token warning so the message goes through the structured logger
- services: surface config-load errors with console.warn including the
  file path and error details instead of silently falling back to {}

https://claude.ai/code/session_01MAw1iz4srnJs7oBbqFPwZg
@Haehnchen Haehnchen merged commit 6bdde12 into Haehnchen:master Feb 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants