fix: address security and reliability issues found in code review#355
Merged
Haehnchen merged 1 commit intoHaehnchen:masterfrom Feb 27, 2026
Merged
Conversation
- strategy_registry: add isSafeStrategyName() to reject names with path
traversal chars; add isPathWithinStrategiesDir() to confine file loads
to var/strategies/; remove arbitrary direct-file-path resolution branch
- bot_runner: attach .catch() handlers to both the initial and recurring
onTick() calls so async errors are logged instead of silently swallowed
- services: fix loose equality (== → ===) for mail port 465 check
- services: replace console.log with this.getLogger().info() for Telegram
missing-token warning so the message goes through the structured logger
- services: surface config-load errors with console.warn including the
file path and error details instead of silently falling back to {}
https://claude.ai/code/session_01MAw1iz4srnJs7oBbqFPwZg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://claude.ai/code/session_01MAw1iz4srnJs7oBbqFPwZg